terraform-provider-docker icon indicating copy to clipboard operation
terraform-provider-docker copied to clipboard

Published 20 hours ago • verified publisher icon kreuzwerker

fix: Optimize tests and CI/CD by using smaller docker images

Open Junkern opened this issue 3 years ago • 0 comments

This PR unifies the image usage in (mostly) tests.

I noticed this, because I could not run some tests locally. The crux image is not maintained anymore since over 2 years, and thus, has no arm64 image (I am running an M1 mac).

In addition, the busybox:1.35.0 is almost 60 MB smaller than the nginx:latest, so that will hopefully also account for some time reduction in CI/CD.

Things I noticed while debugging:

  • Many tests implicit assume that the container keeps running. A simple busybox does not suffice, because it instantly exists. Then test fail, because they can't cleanup
  • Tests with networking need an image which expose a port. Simple busybox does not work here, either

Junkern avatar Jun 22 '22 15:06 Junkern