incr_dom build is broken

[krausest]

trafficstars

Builing incr_dom fails in the docker container and locally. The following error occurs in the docker build:

> esy @esy install

info install 0.6.7 (using esy.json)
info fetching: done                                                                                    
error command failed: 'tar' 'xf' '/build/frameworks/non-keyed/incr_dom/_esy/default/dist/e7eda1500b589a2f164a69a4e04e32d0' '-C' '/tmp/esy-909b1a'
      stderr:
               tar (child): lbzip2: Cannot exec: No such file or directory
               tar (child): Error is not recoverable: exiting now
               tar: Child returned status 2
               tar: Error is not recoverable: exiting now
               
      stdout:
               
error command failed: 'tar' 'xf' '/build/frameworks/non-keyed/incr_dom/_esy/default/dist/ac13f24928fd8c3868f7141f9da38033' '-C' '/tmp/esy-0168cc'
      stderr:
               tar (child): lbzip2: Cannot exec: No such file or directory
               tar (child): Error is not recoverable: exiting now
               tar: Child returned status 2
               tar: Error is not recoverable: exiting now
               
      stdout:
               
error: error running command                  
  unpacking @opam/dune@opam:2.7.1
  installing @opam/dune@opam:2.7.1
esy: exiting due to errors above

and the following is the results in Fedora 35:

    make[3]: Entering directory '/home/stefan/.esy/3/b/ocaml-4.9.1000-ffe51dac/runtime'
    gcc -c -O2 -fno-strict-aliasing -fwrapv -Wall -Werror -fno-common -fno-tree-vrp -g -D_FILE_OFFSET_BITS=64 -D_REENTRANT -DCAML_NAME_SPACE  -DOCAML_STDLIB_DIR='"/home/stefan/.esy/3___________________________________________________________________/s/ocaml-4.9.1000-ffe51dac/lib/ocaml"'  -DNATIVE_CODE -DTARGET_amd64 -DMODEL_default -DSYS_linux   -o startup_aux_n.o startup_aux.c
    gcc -c -O2 -fno-strict-aliasing -fwrapv -Wall -Werror -fno-common -fno-tree-vrp -g -D_FILE_OFFSET_BITS=64 -D_REENTRANT -DCAML_NAME_SPACE  -DOCAML_STDLIB_DIR='"/home/stefan/.esy/3___________________________________________________________________/s/ocaml-4.9.1000-ffe51dac/lib/ocaml"'  -DNATIVE_CODE -DTARGET_amd64 -DMODEL_default -DSYS_linux   -o startup_nat_n.o startup_nat.c
    gcc -c -O2 -fno-strict-aliasing -fwrapv -Wall -Werror -fno-common -fno-tree-vrp -g -D_FILE_OFFSET_BITS=64 -D_REENTRANT -DCAML_NAME_SPACE  -DOCAML_STDLIB_DIR='"/home/stefan/.esy/3___________________________________________________________________/s/ocaml-4.9.1000-ffe51dac/lib/ocaml"'  -DNATIVE_CODE -DTARGET_amd64 -DMODEL_default -DSYS_linux   -o main_n.o main.c
    gcc -c -O2 -fno-strict-aliasing -fwrapv -Wall -Werror -fno-common -fno-tree-vrp -g -D_FILE_OFFSET_BITS=64 -D_REENTRANT -DCAML_NAME_SPACE  -DOCAML_STDLIB_DIR='"/home/stefan/.esy/3___________________________________________________________________/s/ocaml-4.9.1000-ffe51dac/lib/ocaml"'  -DNATIVE_CODE -DTARGET_amd64 -DMODEL_default -DSYS_linux   -o fail_nat_n.o fail_nat.c
    gcc -c -O2 -fno-strict-aliasing -fwrapv -Wall -Werror -fno-common -fno-tree-vrp -g -D_FILE_OFFSET_BITS=64 -D_REENTRANT -DCAML_NAME_SPACE  -DOCAML_STDLIB_DIR='"/home/stefan/.esy/3___________________________________________________________________/s/ocaml-4.9.1000-ffe51dac/lib/ocaml"'  -DNATIVE_CODE -DTARGET_amd64 -DMODEL_default -DSYS_linux   -o roots_nat_n.o roots_nat.c
    gcc -c -O2 -fno-strict-aliasing -fwrapv -Wall -Werror -fno-common -fno-tree-vrp -g -D_FILE_OFFSET_BITS=64 -D_REENTRANT -DCAML_NAME_SPACE  -DOCAML_STDLIB_DIR='"/home/stefan/.esy/3___________________________________________________________________/s/ocaml-4.9.1000-ffe51dac/lib/ocaml"'  -DNATIVE_CODE -DTARGET_amd64 -DMODEL_default -DSYS_linux   -o signals_n.o signals.c
    gcc -c -O2 -fno-strict-aliasing -fwrapv -Wall -Werror -fno-common -fno-tree-vrp -g -D_FILE_OFFSET_BITS=64 -D_REENTRANT -DCAML_NAME_SPACE  -DOCAML_STDLIB_DIR='"/home/stefan/.esy/3___________________________________________________________________/s/ocaml-4.9.1000-ffe51dac/lib/ocaml"'  -DNATIVE_CODE -DTARGET_amd64 -DMODEL_default -DSYS_linux   -o signals_nat_n.o signals_nat.c
    gcc -c -O2 -fno-strict-aliasing -fwrapv -Wall -Werror -fno-common -fno-tree-vrp -g -D_FILE_OFFSET_BITS=64 -D_REENTRANT -DCAML_NAME_SPACE  -DOCAML_STDLIB_DIR='"/home/stefan/.esy/3___________________________________________________________________/s/ocaml-4.9.1000-ffe51dac/lib/ocaml"'  -DNATIVE_CODE -DTARGET_amd64 -DMODEL_default -DSYS_linux   -o misc_n.o misc.c
    signals_nat.c:185:13: error: variably modified 'sig_alt_stack' at file scope
      185 | static char sig_alt_stack[SIGSTKSZ];
          |             ^~~~~~~~~~~~~
    make[3]: *** [Makefile:343: signals_nat_n.o] Error 1
    make[3]: *** Waiting for unfinished jobs....
    make[3]: Leaving directory '/home/stefan/.esy/3/b/ocaml-4.9.1000-ffe51dac/runtime'
    make[2]: *** [Makefile:1002: makeruntimeopt] Error 2
    make[2]: Leaving directory '/home/stefan/.esy/3/b/ocaml-4.9.1000-ffe51dac'
    make[1]: *** [Makefile:415: opt.opt] Error 2
    make[1]: Leaving directory '/home/stefan/.esy/3/b/ocaml-4.9.1000-ffe51dac'
    make: *** [Makefile:466: world.opt] Error 2
    error: command failed: './esy-build' (exited with 2)
    esy-build-package: exiting with errors above...
    
  building [email protected]
esy: exiting due to errors above

[krausest]

@michaelboulton Do you have an idea how to get the build working again?

[krausest]

I created a folder broken_frameworks and moved incr_dom there. Suggested Policy: For non-keyed frameworks I'd just move frameworks, for keyed-frameworks I'd create an issue and contact the contributor and move the framework after 1 month if it's not fixed.

[michaelboulton]

Hi, sorry I missed this email earlier. I had a go at fixing it but the root problem is to do with building a C dependency. There is a fix for this: https://github.com/ocaml/ocaml/pull/10266 but it's in ocaml 4.13, and the ocaml/reason library only supports ocaml up to 4.11, so there is no easy way to fix this AFAICT (until the reason library is updated)