Stefan Krause

Results 187 comments of Stefan Krause
trafficstars

Yeah, I stumped upon that the version number looked so similar :)

> This week I will then make a PR adding a line about this issue. I would have added earlier, I just didn’t know about it. Sorry. 😕 No problem,...

Yes. If you have the corrections ready you can remove the 1139 flag in package.json in the PR.

Thanks. I think I applied the suggestions for vanillajs-2: * Spaces in the tr template such that createRow can change nodeValue instead of textContent * Clear table by cloning the...

* the click event listener now checks directly the id * clear row was switched back to tbody.textContent = "" Results: ![Screenshot 2024-05-03 at 20 08 10](https://github.com/krausest/js-framework-benchmark/assets/3374055/3b9acca6-16bf-4afb-9c65-b745759e23a7)

Here's vanillajs with appendInline and the other optimizations applied: ![Screenshot 2024-05-03 at 22 25 03](https://github.com/krausest/js-framework-benchmark/assets/3374055/69e32992-6d4a-4898-8fef-ec93c991c1c9) Good improvement for create 10k rows. Sadly create 1k rows is stuck and ivi is...

Thanks so far. I think I can show my concerns with chrome 124 in the following two charts: This is the duration for rendering. Chrome 124 reports about 2.5 msecs...

One example trace for create 1k rows for ivi: ![Screenshot 2024-05-04 at 10 28 13](https://github.com/krausest/js-framework-benchmark/assets/3374055/b9095a27-2926-43c7-a0e5-880e187d44c9) Total duration: 34.91 msecs Script duraton: 3.18 msecs Rendering: 30 msesc (9.71 msecs recalculate style,...

@localvoid Good catch, but it's not causing that effect. This is create 1k rows for ivi **with** the lbl and remove classes (I'll commit that too) and vanillajs **without**: Overall...

@localvoid You're right. I reverted ivi and removed the classes from the vanillajs* implementations. The result (total duration) still looks like that: Now what's interesting is the results for create...