beaver-logger icon indicating copy to clipboard operation
beaver-logger copied to clipboard

Create TypeScript typings

Open mstuart opened this issue 5 years ago • 13 comments

This project isn't written in TypeScript, but many TypeScript users would like to use published typings. For this issue, create TypeScript typings that cover the exported functions, and contribute it back to DefinitelyTyped!

This issue is great for someone who wants to learn more about TypeScript!

mstuart avatar Oct 02 '20 21:10 mstuart

Taking this up! @mstuart

ba11b0y avatar Oct 07 '20 08:10 ba11b0y

@invinciblycool Go for it! Happy hacking

mstuart avatar Oct 13 '20 16:10 mstuart

Hi @invinciblycool, just wanted to follow up. Can you take this up? If not, wanted to leave it open for others to contribute before the end of the month. Thanks!

mstuart avatar Oct 21 '20 04:10 mstuart

Hey @mstuart, sorry for the delay. Sending a PR soon!! :smile:

ba11b0y avatar Oct 21 '20 05:10 ba11b0y

np!!

mstuart avatar Oct 21 '20 05:10 mstuart

Hey @ba11b0y have you had time to finish up? Is there a spot where I eventually could take on the rest of the work if you are missing some parts?

Salketer avatar May 07 '21 12:05 Salketer

Hey Mathieu, I couldn't finish this. You could pick this up. Rahul.

On Fri, May 7, 2021 at 5:43 PM Mathieu Parent @.***> wrote:

Hey @ba11b0y https://github.com/ba11b0y have you had time to finish up? Is there a spot where I eventually could take on the rest of the work if you are missing some parts?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/krakenjs/beaver-logger/issues/36#issuecomment-834320212, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF4MIVLZDKMW23RULX7WM5TTMPKPDANCNFSM4SCFX4WQ .

ba11b0y avatar May 07 '21 16:05 ba11b0y

Hi @Salketer, did you do any work on this? Let me know and I'll assign to you. Thanks!

mstuart avatar Oct 04 '21 16:10 mstuart

Hey there @mstuart nice to see you around. Unfortunately we didn't get the time to advance on this topic. We didn't implement this in our software yet so I can't really say I'm on it... I'm definitely interested in having this/work on it but priorities shifted a bit since last comment...

I'll let you know when we start working on it, but feel free to ping me if there's interest!

Salketer avatar Oct 04 '21 16:10 Salketer

Definitely still interested in someone picking this up. If you're able to later, let me know!

mstuart avatar Oct 04 '21 18:10 mstuart

I would like to work on this. I am basing the work off the pull request for zalgo-promise (https://github.com/DefinitelyTyped/DefinitelyTyped/pull/56179).

I think this requires the pull request for zalgo-promise to be merged first though, because parts of the API has ZalgoPromise types

ispedals avatar Oct 17 '21 17:10 ispedals

@ispedals @types/zalgo-promise has been merged and released

daniel-shuy avatar Oct 25 '21 12:10 daniel-shuy

@daniel-shuy thanks. Created https://github.com/DefinitelyTyped/DefinitelyTyped/pull/56897 to have the types included

ispedals avatar Oct 31 '21 21:10 ispedals