srai
srai copied to clipboard
feat: Datasets with loaders
@RaczeQ @Calychas PR is ready, please check :)
Codecov Report
Attention: Patch coverage is 98.64253% with 3 lines in your changes are missing coverage. Please review.
Project coverage is 90.62%. Comparing base (
5622aa2) to head (aa686c0).
:exclamation: Current head aa686c0 differs from pull request most recent head f01ac4f
Please upload reports for the commit f01ac4f to get more accurate results.
| Files | Patch % | Lines |
|---|---|---|
| srai/datasets/nyc_bike/dataset.py | 93.93% | 2 Missing :warning: |
| srai/datasets/_base.py | 94.44% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #430 +/- ##
==========================================
+ Coverage 89.72% 90.62% +0.89%
==========================================
Files 62 77 +15
Lines 2444 2635 +191
==========================================
+ Hits 2193 2388 +195
+ Misses 251 247 -4
| Flag | Coverage Δ | |
|---|---|---|
| macos-13-python3.12 | ? |
|
| ubuntu-latest-python3.10 | 90.51% <98.64%> (+0.78%) |
:arrow_up: |
| ubuntu-latest-python3.11 | 90.55% <98.64%> (+0.82%) |
:arrow_up: |
| ubuntu-latest-python3.12 | 90.55% <98.64%> (+0.90%) |
:arrow_up: |
| ubuntu-latest-python3.9 | 90.53% <98.64%> (+0.82%) |
:arrow_up: |
| windows-latest-python3.12 | 90.55% <98.64%> (+0.82%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Try to add tests to that and make it pass in ci/cd (you might need to wait on #438 as some issues will be resolved there)
Note:
- change HFDataset to HuggingFaceDataset
- Better export the datasets so no ".dataset" is needed