hello-algo
hello-algo copied to clipboard
Add the TypeScript code and docs for Chapter of Hash Map #113
Added typescript
Hash Map
Checklist
- [x] I've tested the code and ensured the outputs are the same as the outputs of reference codes.
- [x] I've checked the codes (formatting, comments, indentation, file header, etc) carefully.
- [x] The code does not rely on a particular environment or IDE and can be run on a standard system (Win, MacOS, Ubuntu).
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
| Name | Status | Preview | Updated |
|---|---|---|---|
| hello-algo | ⬜️ Ignored (Inspect) | Dec 26, 2022 at 3:12PM (UTC) |
Thank @danielsss for the contribution! Please address the comments.
Hi @krahets, All the issues that you mentioned above have been addressed.
Thanks for the update! Several comments are to be addressed. Additionally, the
hash_map.tsfile is lost, which is designed to introduce the built-in HashMap.
Thanks for your review. The issues are resolved and totally implemented according to the original Typescript syntax.
Thank you! @danielsss I see you are using deno to test but you should know that deno has skipped type-checking by default. You could see the article: denoland/deno#11340 If you use deno to test, you need to use the --check option
deno run --check xxxxxx.tsOr you could use ts-node to test. And then you will see the type error message, please make sure you could pass it.
@justin-tse All the type checks have been resolved, and now it can be passed by --check.