pydantic-pycharm-plugin icon indicating copy to clipboard operation
pydantic-pycharm-plugin copied to clipboard

Update java to 17

Open KotlinIsland opened this issue 3 years ago • 4 comments

And misc changes from the plugin template

KotlinIsland avatar Jul 28 '22 00:07 KotlinIsland

java.lang.RuntimeException: java.lang.IllegalAccessException: module java.base does not open java.lang to unnamed module

What does that mean 🤔

KotlinIsland avatar Jul 28 '22 01:07 KotlinIsland

Probably something to do with Archived non-system classes are disabled because the java.system.class.loader property is specified (value = "com.intellij.util.lang.PathClassLoader"). To use archived non-system classes, this property must not be set Exception in thread "main" java.lang

KotlinIsland avatar Jul 28 '22 01:07 KotlinIsland

Could not write standard input to Gradle Test Executor 1. java.io.IOException: The pipe is being closed 🤔🤔🤔

KotlinIsland avatar Jul 28 '22 01:07 KotlinIsland

@KotlinIsland I just came back. I tried to update java to 17. And I got same error :( I checked other major plugins like IntelliJ-rust. They don't use java 17 yet.

koxudaxi avatar Aug 08 '22 15:08 koxudaxi

@koxudaxi This error is no longer present, now it's just some tests that are failing, I have no idea how to resolve them though, any suggestions?

KotlinIsland avatar Sep 24 '22 05:09 KotlinIsland

@koxudaxi I don't understand why the tests are failing, I have manually tested the plugin in 2022.3 and it appears to be functioning correctly.

KotlinIsland avatar Sep 24 '22 08:09 KotlinIsland

Codecov Report

Base: 73.65% // Head: 73.65% // No change to project coverage :thumbsup:

Coverage data is based on head (b049081) compared to base (843f0ec). Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #519   +/-   ##
=========================================
  Coverage     73.65%   73.65%           
  Complexity      301      301           
=========================================
  Files            23       23           
  Lines          1799     1799           
  Branches        532      532           
=========================================
  Hits           1325     1325           
  Misses          191      191           
  Partials        283      283           
Flag Coverage Δ
unittests 73.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 24 '22 09:09 codecov[bot]

I've changed the platformVersion to 2022.2.1 and that has resolved the failing tests.

KotlinIsland avatar Sep 24 '22 10:09 KotlinIsland