datamodel-code-generator icon indicating copy to clipboard operation
datamodel-code-generator copied to clipboard

Fix/float constraints cast as int

Open FredericOutsight opened this issue 3 years ago • 1 comments
trafficstars

#805 Use BaseModel smart_union option for ConstrainsBase in order to avoid erroneous casts Add related unit tests

FredericOutsight avatar Jul 11 '22 14:07 FredericOutsight

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (a4a53b8) compared to base (e9b6edf). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##            master      #806     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           11        21     +10     
  Lines         1020      2625   +1605     
  Branches       201       619    +418     
===========================================
+ Hits          1020      2625   +1605     
Flag Coverage Δ
unittests 99.92% <99.90%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datamodel_code_generator/model/__init__.py 100.00% <ø> (ø)
datamodel_code_generator/__init__.py 100.00% <100.00%> (ø)
datamodel_code_generator/__main__.py 100.00% <100.00%> (ø)
datamodel_code_generator/format.py 100.00% <100.00%> (ø)
datamodel_code_generator/http.py 100.00% <100.00%> (ø)
datamodel_code_generator/imports.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/base.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/enum.py 100.00% <100.00%> (ø)
...atamodel_code_generator/model/pydantic/__init__.py 100.00% <100.00%> (ø)
...amodel_code_generator/model/pydantic/base_model.py 100.00% <100.00%> (ø)
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jul 27 '22 19:07 codecov[bot]

I'm sorry for my late reply. we should provide the option to add the smart_union option to keep current behavior.

koxudaxi avatar Dec 22 '22 15:12 koxudaxi

Fixed by #993 Thank you

koxudaxi avatar Jan 23 '23 06:01 koxudaxi