datamodel-code-generator icon indicating copy to clipboard operation
datamodel-code-generator copied to clipboard

Fix merging config and args

Open mahdilamb opened this issue 1 year ago • 3 comments

Currently the config and args don't combine if they are sequences or dictionaries. This serves to fix that

mahdilamb avatar Jun 26 '24 23:06 mahdilamb

CodSpeed Performance Report

Merging #2015 will not alter performance

Comparing mahdilamb:fix/merge-config-and-args (3fc6292) with main (e4fa23a)

Summary

✅ 29 untouched benchmarks

codspeed-hq[bot] avatar Jun 27 '24 07:06 codspeed-hq[bot]

@mahdilamb Thank you for creating the PR. The unittest failed. Could you please fix it to keep the current behavior?

koxudaxi avatar Jun 28 '24 17:06 koxudaxi

Will do in the next few days! A bit busy at the moment, but it's on my radar!

mahdilamb avatar Jun 28 '24 19:06 mahdilamb

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (e4fa23a) to head (3fc6292).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2015   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        38           
  Lines         4199      4199           
  Branches       967       968    +1     
=========================================
  Hits          4199      4199           
Flag Coverage Δ
unittests 99.66% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 06 '24 09:07 codecov[bot]

@koxudaxi that should be everything fixed

mahdilamb avatar Jul 08 '24 09:07 mahdilamb

@mahdilamb I'm sorry for the late reply. Thank you very much!!

koxudaxi avatar Aug 06 '24 08:08 koxudaxi