datamodel-code-generator icon indicating copy to clipboard operation
datamodel-code-generator copied to clipboard

Fix reuse_models not using the custom_template_dir

Open atti92 opened this issue 1 year ago • 2 comments

If you try to use --custom-template-dir along with --reuse-model, The reused model is not using the same template as the original.

The initializer is missing the template dir on construction.

atti92 avatar May 10 '24 09:05 atti92

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@5bab627). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1954   +/-   ##
=======================================
  Coverage        ?   98.90%           
=======================================
  Files           ?       37           
  Lines           ?     4193           
  Branches        ?      975           
=======================================
  Hits            ?     4147           
  Misses          ?       29           
  Partials        ?       17           
Flag Coverage Δ
unittests 98.56% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 10 '24 09:05 codecov[bot]

CodSpeed Performance Report

Merging #1954 will not alter performance

Comparing atti92:atti92-reuse-models2 (e817fd5) with main (5bab627)

Summary

✅ 29 untouched benchmarks

codspeed-hq[bot] avatar May 10 '24 09:05 codspeed-hq[bot]