html5-parser icon indicating copy to clipboard operation
html5-parser copied to clipboard

setup.py assumes MSVC on Windows

Open us88 opened this issue 3 years ago • 1 comments
trafficstars

We'd like to use MinGW on Windows to compile this library, though line 22 is appending "/O2" explicitly:

cargs = ('/O2' if iswindows else '-O3').split()

There should probably be something in place to detect if someone is using Microsoft's Compiler or Clang or GCC

us88 avatar Jun 06 '22 08:06 us88

You are welcome to send a patch for it, I never use non-native compilers for platforms that have native compilers.

kovidgoyal avatar Jun 06 '22 10:06 kovidgoyal