Kovid Goyal

Apologies for the long delay, I was focusing on getting kitty-tool done. Now that this is merged into master I have the time to review this PR. Could you please...

Culd you also make a separate PR with some trivial change so thatthe tests are run automatically on thi PR in the future.

I did a basic review, the code looks mostly fine (however with graphics its the end result that matters), I will post visual results that don't look good to my...

I am fairly certain that this change will be liked by some people and hated by others and not noticed at all by many. And we will of course hear...

Another thought is maybe we need different gamma values (aka LUTs) and curves for each platform so that the out of the box rendering is closer to platform defaults. So...

On Mon, Nov 21, 2022 at 07:31:21AM -0800, Martin Wernstål wrote: > > The first thing I noticed is that dark-on-light text looks significantly lighter with the patch. See below,...

Another possible issue is how changing opengl to use SRGB colorspaces interacts with the macos_colorspace setting, is it handled transparently? Does it cause performance issues when the display colorspace is...

OK, that's good to hear.

Do whatever you find easier. I am fine with you opening a new PR if that's easier for you, just link to this one in its text.

Unfortunately I dont have access to this architecture so its not really possible for me to debug. If you do have access to it you might get more useful errors...