gulp-combine-media-queries icon indicating copy to clipboard operation
gulp-combine-media-queries copied to clipboard

Add source map support

Open ckihneman opened this issue 11 years ago • 12 comments

I love the idea here, but I've put a lot of effort into ensuring my source maps work properly. And unfortunately this plugin does not handle them. It throws the media query styles after any source map info right now (the bottom of the file).

For the record, from my tests, the plugin works as expected. For now, I'm just going to move this to a final production build step.

Some thoughts on where to go with this... https://github.com/ai/autoprefixer currently handles this situation. They get CSS piped to them, they look for current source maps, then modify the source map depending on what changes autoprefixer makes, then re-inline the source map. It looks like the author even made a library to help post process css: https://github.com/ai/postcss. Maybe you could leverage his efforts there to make your life easier?

And I found your plugin from this post from yeoman by Addy Osmani. So you may be picking up some more traction.

ckihneman avatar Jun 20 '14 01:06 ckihneman

This would be excellent.

wayferer avatar Aug 07 '14 17:08 wayferer

:+1:

yocontra avatar Jan 13 '15 23:01 yocontra

:+1:

misteroh avatar Jan 27 '15 16:01 misteroh

:+1: yes please address this

chrismillah avatar May 18 '15 21:05 chrismillah

:+1: Would be a great addition

seanogdev avatar Jun 15 '15 14:06 seanogdev

:+1:

waynetheisinger avatar Oct 09 '15 14:10 waynetheisinger

:+1: I would love to see source-maps support for this plugin

robhoeben avatar Dec 15 '15 15:12 robhoeben

:+1:

aliciaj avatar Feb 17 '16 19:02 aliciaj

Struggling with this now. Would be awesome to support sourcemaps

kaisermann avatar Nov 02 '16 16:11 kaisermann

Any news on this?

seothemes avatar Feb 11 '17 11:02 seothemes

My current workaround was to use postcss with css-mqpacker and it works like a charm

kaisermann avatar Feb 12 '17 18:02 kaisermann

Would be awesome to support sourcemaps

superkon avatar Aug 31 '17 03:08 superkon