photon
photon copied to clipboard
komoot
Update fix
-don't expand multiple housenumbers on the same object -use a nominatim instance independent document id -delete documents expanded from interpolations by the osm data
This fixes the remaining update problems outside of https://github.com/openstreetmap/Nominatim/issues/1360 It currently continues to expand address interpolations and in general is rather ugly. As the mapping has changed this requires a re-import.
The alternative is to not expand interpolations, use a distance based scoring to the actual interpolation way and generate individual results from that on the fly. This will require changes to the queries and will have an unknown performance impact.
To explain this a bit better, these changes fix the update issues without changing anything wrt scoring and querying, as they still require changing the id generation and a re-import, it doesn't seem to make sense to not change the id generation in this PR, particularly considering that it isn't clear if a solution with non-expanded interpolations will actually work satisfactory (I'm looking at that, but IMHO it is a separate undertaking). More comments inline.
I think I know how to fix the update mess around expanded housenumbers and interpolations without any changes to the document ID. So finally closing this one.
