kokkos-kernels
kokkos-kernels copied to clipboard
Reduce duplicated code in trsv
A slightly different for loop can avoid having to separate out the last iteration in all the uppertri functions.
@cwpearson , I think it's right. The c==0 part I removed assumed there was only one item, which should hold true in both cases. Oh, it also assumed the c==0 entry is diagonal, which i also think is fine.
@jgfouca we merged a fix for the failing atomics, I think if you rebase on develop the current failures will go away
@lucbv , another option for the backwards loops that may be easier to read:
for (lno_t r = numRows - 1; r != static_cast<lno_t>(-1); --r) {
@lucbv , see if you like the current version better.
@cwpearson are you okay with this, can we merge?