kokkos-kernels icon indicating copy to clipboard operation
kokkos-kernels copied to clipboard

pert tests: each test re-implements standard boiler plate hindering maintenance

Open lucbv opened this issue 2 years ago • 2 comments

@brian-kelley @e10harvey The issue is related to PRs #1624 #1664 and #1672 all of which touch on boiler plate logic. This issue should be resolved by the introduction of utility functions and macros. Here are two proposed enhancement

  1. introduce a struct and functions to handle listing, parsing and setting of common inputs (--cuda, --openmp, etc...)
  2. create a macro that performs some logic checks and picks execution spaces on which to run the performance test

Let me know if additional features would be useful, a PR with the above changes will be issued soon

lucbv avatar Feb 06 '23 16:02 lucbv

Maybe we should lift some of the code in kokkos/core/src/impl/Kokkos_Command_Line_Parsing.cpp? : )

lucbv avatar Feb 08 '23 16:02 lucbv

The other thing worth thinking about is interaction with Google Benchmark, which parses / consumes its own set of CLI arguments (I think they all start with --benchmark_)

cwpearson avatar Feb 20 '23 15:02 cwpearson