kokkos-kernels icon indicating copy to clipboard operation
kokkos-kernels copied to clipboard

Published 20 hours ago • verified publisher icon kokkos

979-shortenwinnames

Open jpopelar opened this issue 4 years ago • 3 comments

This branch aims to trim down the length of some of the variable names used in kokkos-kernels/cmake, as on Windows there are link errors if the names generated in CMake are too long. Currently, we replace instances of MEMSPACE_HOSTSPACE to HOSTSP.

We are submitting this pull request to initiate a discussion on the desired approach. We note that TPetra does something similar, but with shorter instance names, and there are no problems in building TPetra.

jpopelar avatar May 27 '21 20:05 jpopelar

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

kokkos-devops-admin avatar May 27 '21 20:05 kokkos-devops-admin

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

kokkos-devops-admin avatar Aug 24 '23 07:08 kokkos-devops-admin

This looks newer than related https://github.com/kokkos/kokkos-kernels/issues/395

cwpearson avatar May 22 '24 19:05 cwpearson