Klemens Böswirth
Klemens Böswirth
> I don't think we should change this in this PR. Such last minute things make more harm than good. So let us keep kdbCommit for now. I wouldn't change...
@markus2330 I think I have now fixed all the tests I can. I'll wait for the CI and disable anything that still fails. Is there anything in your review that...
> I can't run these for whatever reason (probably missing dependency), I think some of these plugins don't have dependencies. You probably haven't enabled them in CMake. When you run...
Hm yeah you're right. Let's leave it the way it is. We'll fix it in another PR at some point. Although something needs to change, because the failing tests haven't...
Actually, I would 1. Move the full code of `ksLookup` into `ksSearch` 2. Rewrite that code (i.e. all the functions called by `ksLookup`/`ksSearch`) to return a `elektraCursor` instead of a...
> it does not matter anymore what the default storage is, as it is unused Not true, the default storage plugin is still used, if no storage plugin is defined...
> This issue is about a proposal to introduce default mountpoints via the normal mount mechanism and disable the current "default mountpoints" (replace by using an error plugin, which cannot...
cc @hannes99 @markus2330
> Are you sure that simply inserting the keys, possibly kicking out other keys that were there, is safe with our definition of backends in the new-backend branch? It would...
Actually this issue is very simple to fix... There is [a `clang-tidy` check](https://releases.llvm.org/11.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/readability-braces-around-statements.html) that checks whether all `if`s use braces. It can also be automatically fixed with ``` clang-tidy /path/to/file.c...