Klemens Böswirth
Klemens Böswirth
@markus2330 I updated the PR
> Who wants to be second reviewer? No idea who would be best, but you probably need to tag someone or we need to bring it up in the next...
@markus2330 Can this be merged now? If so, I will resolve the merge conflict.
> I already approved before I made more changes after the review, that's why I re-requested the review. > Please write my reservation in the notes of [header_include.md](https://github.com/ElektraInitiative/libelektra/pull/4246/files#diff-d73b4e18afecf3f9b6fe38faf66f2151e657c678e43fa37acf126723d8daadf5) The decision...
@markus2330 rebased, please merge when CI is done
> ansicolors (nice coloring of output, especially for errors) To add to this: coloring should only happen, when outputting to a TTY (see `isatty(3)`). > Btw. it would be nice...
The namespace for metadata is called `meta:/` not `metadata:/`
You correctly identified the `get` and `set` methods this issue is about. In theory they should have the exact same behaviour, except that `get` should only produce warnings where `set`...
Correct, the code duplication should be minimized for the sake of maintainability. How you achieve this is up to you. Extracting the checks is one possibility, another possibility would be...
> The quickest (albeit, not the most readable) solution I think the solution is fine, but we might want to have a different name instead of `setValidationProblem` to make it...