kobalte
kobalte copied to clipboard
kobaltedev
feat: carousel component using embla carousel
Deploy Preview for kobalte ready!
| Name | Link |
|---|---|
| Latest commit | 77eab5dc64a8179ca17d3ad05f2963335a7c9005 |
| Latest deploy log | https://app.netlify.com/sites/kobalte/deploys/6741681e07faae0008f4c0eb |
| Deploy Preview | https://deploy-preview-527--kobalte.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
Lighthouse |
1 paths audited Performance: 84 (🟢 up 41 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 82 (no change from production) PWA: 60 (🔴 down 10 from production) View the detailed breakdown and full score reports |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Waishnav Might want to check if using embla-carousel dependency is allowed.
From what I understand, UI primitive libraries like this one will generally avoid adding dependencies.
@Waishnav Might want to check if using
embla-carouseldependency is allowed.From what I understand, UI primitive libraries like this one will generally avoid adding dependencies.
Hmm make sense @jer3m01, I'd love to hear your thoughts and any suggestions on how we might proceed with implementing this. Thank you both for your insights!
Thanks for the draft!
I think this could be a good component, rewriting an entire carousel is out of scope for now. Using embla (specifically https://www.embla-carousel.com/get-started/solid/) should be the way forward.
The API should ideally be fully wrapped in Kobalte with props on the Carousel.Root for all embla options. (The end user should not access embla themselves).
Only the interactivity should be left to embla, so that the entire layout of the component is generated during SSR.
Looking forward to this, good luck!
Hey @jer3m01,
I've implemented all the suggestions from your previous message.
The Carousel component now uses Embla under the hood and exposes it through the options and plugins props, allowing users to enjoy the flexibility and power of Embla while retaining full control.
With Kobalte's WAI-ARIA compliance and unstyled component philosophy, users can now compose their own custom carousel components as needed.
That said, I’m still relatively new to writing composable UI components in this pattern. I’d greatly appreciate it if you could review it thoroughly and share any feedback or suggestions for improvement. Looking forward to iterating further based on your input!
one more thing, should we add the keyboard interaction support just like we have for Tabs component?
Rapidly clicking on the buttons don’t move the slides faster. They seem to be stuck.
Also examples are broken on my phone. I think it is because you are using css nesting which is relatively new.
Yes it would be good to support prev/next with arrow and first/last with home/end.
Hey, I've added the keyboard interaction for better accessibility. Please let me know if there is any further changes needed