kobalte icon indicating copy to clipboard operation
kobalte copied to clipboard

fix(combobox): destructive fix #514 - do not freeze popover content nor display old options

Open MengLinMaker opened this issue 1 year ago • 2 comments
trafficstars

Destructive fix

closes #514

This removes the ability to freeze content as options update when popover is closed.

Freezing content and displaying old options seem like a weird behaviour. Unless I'm missing something.

Note: combobox test is skipped. Unskipping leads to failed tests since popover fails to open - see issue #254

MengLinMaker avatar Nov 10 '24 09:11 MengLinMaker

Deploy Preview for kobalte ready!

Name Link
Latest commit 22dff17b76a7a07a731010f75f61c85a79d87efa
Latest deploy log https://app.netlify.com/projects/kobalte/deploys/67307a15bf71a50008b35a69
Deploy Preview https://deploy-preview-526--kobalte.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 70 (🔴 down 13 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: 60 (🔴 down 10 from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Nov 10 '24 09:11 netlify[bot]

Idea for non destructive fix

Can add a prop to disable this behaviour. Though this solution seems jank.

MengLinMaker avatar Nov 10 '24 09:11 MengLinMaker