defmt icon indicating copy to clipboard operation
defmt copied to clipboard

Define an MSRV

Open MabezDev opened this issue 1 year ago • 3 comments
trafficstars

The readme states the MSRV is the latest stable Rust, but I think now that defmt is a staple in the embedded-rust ecosystem you should consider picking an MSRV and only bumping when needed (and subsequently bumping the version in a semver compatible way too).

MabezDev avatar Mar 11 '24 15:03 MabezDev

How is this handled usually? Do we build and test against the latest stable and the MSRV in CI?

subsequently bumping the version in a semver compatible way too

What do you mean by that? Would you consider it a breaking change if the MSRV is bumped?

Urhengulas avatar Mar 20 '24 12:03 Urhengulas

How is this handled usually? Do we build and test against the latest stable and the MSRV in CI?

Yes.

What do you mean by that? Would you consider it a breaking change if the MSRV is bumped?

There doesn't seem to be a clear answer here, at least upstream Rust hasn't taken a stance. In general though, unless defmt needs to opt in to new features, keeping MSRV as latest STABLE seems a bit silly, especially since defmt is used so widely in the ecosystem.

MabezDev avatar Mar 26 '24 11:03 MabezDev

I suspect we'll tie the MSRV to Ferrocene's upstream equivalents.

thejpster avatar May 17 '24 16:05 thejpster

@jonathanpallant said:

Our effective MSRV is currently Ferrocene 24.05 (Rust 1.76.0) and so we should clarify that in the README.

Urhengulas avatar Oct 09 '24 10:10 Urhengulas

Fixed by https://github.com/knurling-rs/defmt/pull/871.

Urhengulas avatar Oct 11 '24 14:10 Urhengulas