Ian

Results 32 comments of Ian

@JoelSpeed is there any plans in the near future to fix Azure sign in so we can use the Azure provider again instead of generic oidc? It would help to...

SAME!!!! `[2022/05/31 02:44:27] [main.go:60] ERROR: Failed to initialise OAuth2 Proxy: error intiailising provider: could not create provider data: error building OIDC ProviderVerifier: invalid provider verifier options: missing required setting: issuer-url`...

Looks like GitHub auth is also having issues. Is there any pertinent security issues that are addressed in this or is it fine to roll back and live on 7.2.1?

> > Looks like GitHub auth is also having issues. Is there any pertinent security issues that are addressed in this or is it fine to roll back and live...

@JoelSpeed --oidc-issuer-url="https://sts.windows.net/{tenant-id-here}/ but I wasn't using --oidc-issuer-url in 7.2.1 so I just added it as per the documentation I think Can confirm what @erikgb says in that changing provider=oidc doesn't...

> Unless there are serious objections from the Azure users on this thread, I will retrospectively add a breaking change note to the changelog saying that users are now required...

> Azure package has these lines: > > ``` > if p.ValidateURL == nil || p.ValidateURL.String() == "" { > p.ValidateURL = p.ProfileURL > } > ``` > > So...

Yep v7.3 is completely broken and should never have been released as latest stable IMO. Azure auth is also completely borked.

> Maybe i'm wrong but i think this only work (or at least the modal is made) for inbound traffic Surely not? How can you have a destination of 8.8.8.8...

> if you don't wont to follow RFCs you are free to use also 8.8.8.8 as a LAN ip so nothing wrong if it was the case ;) but more...