Add a config flag to use service name in traces

[pomyslowynick]

Proposed Changes

• Use a flag to use ServingServiceas the trace service.name which is added in this PR

Motivation is pretty much the same as in the other PR, copy pasting:

While the OTel migration is in progress it would be very helpful to have a flag which allows users toggling the ServingService to be used as the service.name in traces. This is related to https://github.com/knative/serving/issues/12969 and would still be relevant after the migration to OTel.

Release Note

You can now use the `useServingService` flag in the tracing config to use the `ServingService` as the `service.name` in traces. Current default is to use the `ServingPod` as the `service.name`, and it remains the same if the flag is not set.

[linux-foundation-easycla[bot]]

• :white_check_mark:login: pomyslowynick / (3c021e53da8f284773bf65f23ddbd67b5905427a)

The committers listed above are authorized under a signed CLA.

[knative-prow[bot]]

Welcome @pomyslowynick! It looks like this is your first PR to knative/serving 🎉

[knative-prow[bot]]

Hi @pomyslowynick. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[knative-prow[bot]]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pomyslowynick Once this PR has been reviewed and has the lgtm label, please assign skonto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[dprotaso]

/hold

Made a comment here - https://github.com/knative/pkg/pull/3164#issuecomment-2800126864

I want to revisit our OTel approach after the next release. That might require breaking changes and we'd probably make this change without a config map flag.

[pomyslowynick]

/hold

Made a comment here - knative/pkg#3164 (comment)

I want to revisit our OTel approach after the next release. That might require breaking changes and we'd probably make this change without a config map flag.

Happy to help with OTel migration if that brings us closer to resolving this issue, if there's a need.

[knative-prow-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dprotaso]

Our OTel migrations have landed - and we use the service name if it's associated with one