Fix panic on DeletedFinalStateUnknown in ConfigMap informer
Fixes #3220
- :white_check_mark: login: anjalii-28 / name: Anjali (33ffc8e86ef31a034fb27ca2b8e7b39a59a04669, e0d3659b43ae031f7316462e5c6dc71905a5e479)
- :x: The email address for the commit (f95d5340e39c5f4af3b020e10d5c459938cc84ea) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.
Hi @anjalii-28. Thanks for your PR.
I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
This PR fixes the panic caused by DeletedFinalStateUnknown in the ConfigMap informer and adds tests to ensure delete events are handled safely.
PTAL, thanks!
/ok-to-test
You'll need to sign the CLA - see this comment https://github.com/knative/pkg/pull/3301#issuecomment-3649871422
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 74.62%. Comparing base (e853b1d) to head (e0d3659).
:warning: Report is 4 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #3301 +/- ##
==========================================
+ Coverage 74.58% 74.62% +0.03%
==========================================
Files 188 188
Lines 8187 8192 +5
==========================================
+ Hits 6106 6113 +7
+ Misses 1841 1840 -1
+ Partials 240 239 -1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
/easycla
/lgtm /approve
Thanks for the change - let me know when you sort out the EasyCLA
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: anjalii-28, dprotaso
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [dprotaso]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
New changes are detected. LGTM label has been removed.
/easycla
easy cla isn't satisfied - unsure if you need to sign older commits?
git rebase --signoff HEAD~N
Generally though I thought it was tied to the email in your github account
I'm not really an EasyCLA expert so you'll want to open an issue here: https://github.com/linuxfoundation/easycla