docs icon indicating copy to clipboard operation
docs copied to clipboard

Published 20 hours ago • verified publisher icon knative

Apply New Designs to Case Studies Section

Open rohitsrma opened this issue 1 year ago • 6 comments
trafficstars

In this PR I've implemented the new designs for the case studies section, as provided in the Figma design shared by @mmejia02

Before

Untitled design (1)

After

new (2)

rohitsrma avatar May 10 '24 18:05 rohitsrma

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rohitsrma Once this PR has been reviewed and has the lgtm label, please assign leo6leo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar May 10 '24 18:05 knative-prow[bot]

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit 0eb6ff2d5a63388093f898515d1a51185e1f02b7
Latest deploy log https://app.netlify.com/sites/knative/deploys/664cf1f17f2e7a0008db7f22
Deploy Preview https://deploy-preview-5962--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 10 '24 18:05 netlify[bot]

@rohitsrma, I think you should fix the following:-

  1. The font style should be changed to Roboto.
  2. In mobile mode, the margin should be increased between two blocks.
  3. the "case study" font and style do not match the design in mobile mode.

shivamgupta2020 avatar May 20 '24 19:05 shivamgupta2020

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow-robot avatar May 28 '24 06:05 knative-prow-robot

/close this was superceded by #6032

Cali0707 avatar Jul 18 '24 18:07 Cali0707

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen with /reopen. Mark as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Oct 17 '24 01:10 github-actions[bot]