docs icon indicating copy to clipboard operation
docs copied to clipboard

Fixed markdown syntax in Python serving README.md

Open dhruvy1 opened this issue 3 years ago • 7 comments

This PR fixes markdown syntax in the serving/hello-world/helloworld-python/README.md file. Making it easier to read for new starters.

"Fixes #issue-number" or "Add description of the problem this PR solves"

Proposed Changes

  • Update markdown syntax in serving/hello-world/helloworld-python/README.md file

dhruvy1 avatar Aug 31 '22 12:08 dhruvy1

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: dhruvy1 / name: Dhruv (f8767939063d0837227c8eaba088d1f66f0220c0)

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit f8767939063d0837227c8eaba088d1f66f0220c0
Latest deploy log https://app.netlify.com/sites/knative/deploys/630f56d5947d2800085c318b
Deploy Preview https://deploy-preview-5206--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 31 '22 12:08 netlify[bot]

Welcome @dhruvy1! It looks like this is your first PR to knative/docs 🎉

knative-prow[bot] avatar Aug 31 '22 12:08 knative-prow[bot]

Hi @dhruvy1. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow[bot] avatar Aug 31 '22 12:08 knative-prow[bot]

/ok-to-test /hold

abrennan89 avatar Aug 31 '22 16:08 abrennan89

@dhruvy1 thanks for the PR! I've added a few comments, mostly about formatting or suggestions for readability of content.

abrennan89 avatar Aug 31 '22 16:08 abrennan89

/lgtm /approve

Would've been nice to have had review comments implemented, but merging anyway since I don't want this issue to get stale. @dhruvy1 for future PRs, please follow the style guide to ensure docs are consistent. Thanks.

abrennan89 avatar Oct 11 '22 16:10 abrennan89

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, dhruvy1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Oct 11 '22 16:10 knative-prow[bot]