Kevin Squire

Results 140 comments of Kevin Squire

Monads.jl does have a bind method.

The request here seems to be only abstractly related to `Result` types (as I understand them), and the corresponding Julia issue was closed (with a PR that implements essentially what...

FWIW, the test failures are all the same error, which should be fixed, but should have nothing to do with this PR.

@dcherian Thanks. I thought I was done, but I'm finding things that aren't working as expected. I'm working on adding more tests for expected behavior, so marking as WIP. Will...

@dcherian Okay, I think this is in good shape. I added some more tests, and fixed a few more bugs. Most of the fixes have been squashed back down to...

Also, FWIW, the test failure was caused by a problem in zarr/fsspec (https://github.com/intake/filesystem_spec/issues/707), which is fixed in master on fsspec (https://github.com/intake/filesystem_spec/pull/710). So it should be fixed here whenever fsspec makes...

@dcherian Thank you for reviewing. I've started working through your comments.

> The code also introduces a problem, the following no longer works: > ``` > xr.DataArray([1, 2, 3], coords=dict(x=[1, 1, 1])).rolling(x=3).mean() > ``` > thus you may have to use...

Mentioned in one of the comments above, but I think I've reached about the amount of time that I can spend on this right now. If there are other minor...

> There was some discussion about syntax at the dev meeting today. There were multiple votes in favour of allowing full control of padding in the rolling object itself. So...