dfp-prebid-setup icon indicating copy to clipboard operation
dfp-prebid-setup copied to clipboard

Support one order for all bidders (no PREBID_BIDDER_CODE)

Open ptomasroos opened this issue 8 years ago • 6 comments

In the case of not wanting to have one order per bidder rather using a global one by just targeting hb_pb we should allow a None PREBID_BIDDER_CODE

Same approach is recommended in the video tutorial how to setup prebid in DFP http://prebid.org/adops/step-by-step.html

ptomasroos avatar Apr 24 '17 11:04 ptomasroos

I agree that this would be a good improvement.

If we add this, I'd like to generalize the key-value targeting. Right now, we call dfp.create_line_items.create_line_item_config with arguments specific to hb_bidder and hb_pb. Preferably, we can just pass a dict and exclude hb_bidder when it's not set. This would also make it easier to add custom key-value targeting down the line.

kmjennison avatar May 01 '17 23:05 kmjennison

Agreed, this would be helpful/major time and complexity savor.

Slind14 avatar May 25 '17 19:05 Slind14

I would like this too. Has someone managed to modify this such that hb_bidder is not required?

sparklette avatar Jun 20 '17 12:06 sparklette

Quick & dirty workaround:

Within create_line_items.py, changed the logicalOperator to OR and children criteria both as hp_pb

'logicalOperator': 'AND', 'children': [hb_bidder_criteria, hb_pb_criteria] to

'logicalOperator': 'OR', 'children': [hb_pb_criteria, hb_pb_criteria]

This looks silly, but got the desired results in DFP.

image

sujithvn avatar Nov 05 '17 09:11 sujithvn

I'd love to see how I can change this behavior too. I did what @sujithvn mentioned above but it didn't seem to work as it threw an error. Anyway I can modify this tool to accept multiple BidderCodes or none? The normal behavior of Prebid is to accept multiple bidders and not to be only associated with only one (ex. AppNexus, Sovrn, IndexExchange, Rubicon, etc).

Any help would be greatly appreciated.

alberteltawil avatar Jan 31 '18 17:01 alberteltawil

Did anyone find another workaround they can share?

mercuryyy avatar Mar 23 '18 15:03 mercuryyy