grunt-mocha icon indicating copy to clipboard operation
grunt-mocha copied to clipboard

Screenshotting support

Open bjfletcher opened this issue 11 years ago • 8 comments
trafficstars

I have added API for creating screenshots and for changing the viewpoint resolution. The API from Mocha to PhantomJS is achieved using specific console.log's that PhantomJS listens to. I have tested this and working well.

bjfletcher avatar Jan 30 '14 19:01 bjfletcher

ping

pungoyal avatar Sep 21 '14 05:09 pungoyal

Thanks for the ping :) I will make the changes and get back to you guys. On 21 Sep 2014 06:02, "Puneet Goyal" [email protected] wrote:

ping

— Reply to this email directly or view it on GitHub https://github.com/kmiyashiro/grunt-mocha/pull/109#issuecomment-56289279 .

bjfletcher avatar Sep 21 '14 07:09 bjfletcher

@robcolburn I have pulled upstream and fixed the package.json. See also my responses to your suggestions above.

bjfletcher avatar Oct 06 '14 21:10 bjfletcher

@bjfletcher, this looks good to me, though I'm not a maintainer on this module. Just hoping to help out the process for a someone who is.

robcolburn avatar Oct 07 '14 16:10 robcolburn

Is there a reason this hasn't been merged yet? This would be really useful to me.

pimterry avatar Jul 14 '15 18:07 pimterry

@pimterry have you tried using it and seeing if it actually works how you think it would?

kmiyashiro avatar Jul 14 '15 18:07 kmiyashiro

Nope, for various reasons (this, and some PhantomJS issues that would need me to get PhantomJS 2 working, which seems to be pretty impractical) I've moved to Karma + Chrome instead, which means I can just look at the browser myself.

There are definitely other people using it though, as the fork's been published to NPM as a standalone release on NPM in the meantime: https://www.npmjs.com/package/grunt-mocha-screenshot.

pimterry avatar Jul 19 '15 14:07 pimterry

We used this at Sky in a couple of projects in production for visual regression testing.

This was followed in the build process by a visual comparison step https://github.com/bjfletcher/grunt-screenshot-compare The build process would proceed only if there was no visual regression.

bjfletcher avatar Jul 19 '15 14:07 bjfletcher