kmeshctl install

[thebigbone]

What type of PR is this?

/kind feature

What this PR does / why we need it:

adds install command for kmeshctl which will install all the resources for kmesh in a k8s cluster

Which issue(s) this PR fixes: Fixes #552

Does this PR introduce a user-facing change?:

NONE

[kmesh-bot]

Welcome @thebigbone! It looks like this is your first PR to kmesh-net/kmesh 🎉

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.46%. Comparing base (8c72e4c) to head (1e39cec). Report is 168 commits behind head on main.

see 35 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 865f832...1e39cec. Read the comment docs.

[YaoZengzeng]

The overall framework seems fine for me, @hzxuzhonghu PTAL.

[YaoZengzeng]

ping @hzxuzhonghu

[hzxuzhonghu]

please see above comment, when you set version-=0.5, then you will install kmesh with latest image https://github.com/kmesh-net/kmesh/blob/release-0.5/deploy/yaml/kmesh.yaml#L72

This is not expected, can you replace that image?

I would suggest we support v0.5.0 or 0.5.0 rather than 0.5, see our releases

[thebigbone]

please see above comment, when you set version-=0.5, then you will install kmesh with latest image https://github.com/kmesh-net/kmesh/blob/release-0.5/deploy/yaml/kmesh.yaml#L72

This is not expected, can you replace that image?

I would suggest we support v0.5.0 or 0.5.0 rather than 0.5, see our releases

Should I just replace the image and get the yaml files from main then?

[hzxuzhonghu]

Should I just replace the image and get the yaml files from main than?

This probably not work, think of the case that a yaml is updated because of some new features. The old image may cannot work with the new daemonset yaml

[thebigbone]

Removed the branch and instead using tags now.

[kmesh-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [hzxuzhonghu]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[kmesh-bot]

New changes are detected. LGTM label has been removed.

[kmesh-bot]

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository. Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[thebigbone]

The kube package was changed so it's not able to find ApplyYamlContents

[hzxuzhonghu]

Can you implement this method? Or use helm client https://github.com/kurator-dev/kurator/blob/ac68f35c8799773aea22643e39ca032a20e65fb7/pkg/client/client.go#L66

[LiZhenCheng9527]

@thebigbone This PR can be merged after you pass CI.

[thebigbone]

Can you implement this method? Or use helm client https://github.com/kurator-dev/kurator/blob/ac68f35c8799773aea22643e39ca032a20e65fb7/pkg/client/client.go#L66

Should I use the istio's implementation directly in kube/client.go?

[thebigbone]

ping @LiZhenCheng9527

[thebigbone]

I have implemented the method @LiZhenCheng9527