kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

upgrade golang to 1.23

Open tjons opened this issue 1 year ago • 3 comments

What type of PR is this?

/kind enhancement

What this PR does / why we need it: This PR resolves https://github.com/kmesh-net/kmesh/issues/795 by upgrading the version of go to 1.23.2.

Which issue(s) this PR fixes: Fixes https://github.com/kmesh-net/kmesh/issues/795

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Upgrade go to 1.23.2

tjons avatar Oct 03 '24 13:10 tjons

Welcome @tjons! It looks like this is your first PR to kmesh-net/kmesh 🎉

kmesh-bot avatar Oct 03 '24 13:10 kmesh-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.02%. Comparing base (dc26806) to head (9104616). Report is 8 commits behind head on main.

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 973cbc6...9104616. Read the comment docs.

codecov[bot] avatar Oct 03 '24 13:10 codecov[bot]

lgtm

can you change yhe other github actions gp-version as well

@hzxuzhonghu - done! not sure how I missed those :)

this is a very cool project - I'm excited to learn and contribute more

tjons avatar Oct 08 '24 02:10 tjons

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar Oct 08 '24 03:10 kmesh-bot