kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

implement `kmeshctl version`

Open YaoZengzeng opened this issue 1 year ago • 2 comments

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Implement kmeshctl version to show version of kmeshctl or Kmesh daemon

Which issue(s) this PR fixes: Fixes #898

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


YaoZengzeng avatar Sep 30 '24 02:09 YaoZengzeng

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 53.07%. Comparing base (dc26806) to head (ef71fe9). Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
pkg/status/status_server.go 0.00% 10 Missing :warning:
Files with missing lines Coverage Δ
pkg/status/status_server.go 40.74% <0.00%> (-1.57%) :arrow_down:

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 973cbc6...ef71fe9. Read the comment docs.

codecov[bot] avatar Sep 30 '24 03:09 codecov[bot]

@hzxuzhonghu PTAL

YaoZengzeng avatar Oct 08 '24 06:10 YaoZengzeng

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar Oct 09 '24 02:10 kmesh-bot

@hzxuzhonghu maybe this PR could get merged.

YaoZengzeng avatar Oct 09 '24 06:10 YaoZengzeng

@LiZhenCheng9527 Any other comments?

hzxuzhonghu avatar Oct 09 '24 07:10 hzxuzhonghu

ping @LiZhenCheng9527

YaoZengzeng avatar Oct 10 '24 01:10 YaoZengzeng

/lgtm

LiZhenCheng9527 avatar Oct 10 '24 01:10 LiZhenCheng9527