kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

rm depends/include/bpf_helper_defs_ext.h

Open hzxuzhonghu opened this issue 1 year ago • 3 comments

What type of PR is this?

What this PR does / why we need it:

bpf/include/bpf_helper_defs_ext.h is generated from this depends/include/bpf_helper_defs_ext.h

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


hzxuzhonghu avatar Sep 30 '24 01:09 hzxuzhonghu

/lgtm

LiZhenCheng9527 avatar Sep 30 '24 02:09 LiZhenCheng9527

/retest

Weird, this test failed

=== NAME  TestHandleKmeshManage/10._ns_without_label,_pod_ready_add_without_annotation
    manage_controller_test.go:186: 
        	Error Trace:	/home/runner/work/kmesh/kmesh/pkg/controller/manage/manage_controller_test.go:186
        	            				/home/runner/work/kmesh/kmesh/pkg/controller/manage/manage_controller_test.go:425
        	Error:      	Not equal: 
        	            	expected: false
        	            	actual  : true
        	Test:       	TestHandleKmeshManage/10._ns_without_label,_pod_ready_add_without_annotation
        	Messages:   	unexpected value for disabled flag

@Okabe-Rintarou-0

hzxuzhonghu avatar Oct 08 '24 03:10 hzxuzhonghu

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.91%. Comparing base (ef71fe9) to head (0a7735d). Report is 38 commits behind head on main.

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 18c383a...0a7735d. Read the comment docs.

codecov[bot] avatar Oct 08 '24 03:10 codecov[bot]

/assign @lec-bit

hzxuzhonghu avatar Oct 10 '24 03:10 hzxuzhonghu

/lgtm /approve

nlgwcy avatar Oct 12 '24 03:10 nlgwcy

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlgwcy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar Oct 12 '24 03:10 kmesh-bot