kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

Kmesh ads mode cluster add consistent hash lb

Open bfforever opened this issue 1 year ago • 1 comments

What type of PR is this? /kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes: proposal

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


bfforever avatar Sep 23 '24 16:09 bfforever

Codecov Report

Attention: Patch coverage is 67.77778% with 87 lines in your changes missing coverage. Please review.

Project coverage is 50.25%. Comparing base (e9af645) to head (90312f8). Report is 81 commits behind head on main.

Files with missing lines Patch % Lines
pkg/consistenthash/maglev/maglev.go 68.65% 28 Missing and 14 partials :warning:
pkg/controller/ads/cache.go 0.00% 19 Missing :warning:
pkg/utils/hash/murmur3.go 83.48% 18 Missing :warning:
pkg/cache/v2/cluster.go 0.00% 4 Missing and 1 partial :warning:
pkg/bpf/ads/loader.go 0.00% 2 Missing and 1 partial :warning:
Files with missing lines Coverage Δ
pkg/bpf/ads/loader.go 45.67% <0.00%> (-1.76%) :arrow_down:
pkg/cache/v2/cluster.go 45.65% <0.00%> (-1.72%) :arrow_down:
pkg/utils/hash/murmur3.go 83.48% <83.48%> (ø)
pkg/controller/ads/cache.go 45.96% <0.00%> (-2.72%) :arrow_down:
pkg/consistenthash/maglev/maglev.go 68.65% <68.65%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a94c2d1...90312f8. Read the comment docs.

codecov[bot] avatar Oct 30 '24 13:10 codecov[bot]

/lgtm /approve

supercharge-xsy avatar Oct 31 '24 11:10 supercharge-xsy

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: supercharge-xsy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [supercharge-xsy]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar Oct 31 '24 11:10 kmesh-bot