kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

feat: now release automatically does helm push

Open byhlel opened this issue 1 year ago • 10 comments

What type of PR is this?

/kind enhancement

What this PR does / why we need it: Automatically pushes to helm

Which issue(s) this PR fixes: Fixes #841

Special notes for your reviewer: I am not sure whether it should be in it's own job or within the build one

Does this PR introduce a user-facing change?:

NONE

byhlel avatar Sep 23 '24 05:09 byhlel

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign nlgwcy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar Sep 23 '24 05:09 kmesh-bot

Welcome @byhlel! It looks like this is your first PR to kmesh-net/kmesh 🎉

kmesh-bot avatar Sep 23 '24 05:09 kmesh-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.22%. Comparing base (1225450) to head (f4178ee). Report is 28 commits behind head on main.

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 22d9fdf...f4178ee. Read the comment docs.

codecov[bot] avatar Sep 23 '24 05:09 codecov[bot]

@byhlel can we have a quick talk in slack or wechat in case this is in the wrong direction

hzxuzhonghu avatar Sep 24 '24 06:09 hzxuzhonghu

Yes on slack, my email: [email protected]

byhlel avatar Sep 24 '24 07:09 byhlel

Have you joined this channel https://cloud-native.slack.com/archives/C06BU2GB8NL, and then you can contact with Zhonghu Xu

hzxuzhonghu avatar Sep 24 '24 07:09 hzxuzhonghu

@byhlel Can you please update

hzxuzhonghu avatar Sep 25 '24 07:09 hzxuzhonghu

Updated per our discussion

byhlel avatar Sep 26 '24 05:09 byhlel

@byhlel I have left some message to you in slack

hzxuzhonghu avatar Sep 26 '24 07:09 hzxuzhonghu

ping @byhlel please update

hzxuzhonghu avatar Oct 10 '24 03:10 hzxuzhonghu