feat: now release automatically does helm push
What type of PR is this?
/kind enhancement
What this PR does / why we need it: Automatically pushes to helm
Which issue(s) this PR fixes: Fixes #841
Special notes for your reviewer: I am not sure whether it should be in it's own job or within the build one
Does this PR introduce a user-facing change?:
NONE
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign nlgwcy for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Welcome @byhlel! It looks like this is your first PR to kmesh-net/kmesh 🎉
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 53.22%. Comparing base (
1225450) to head (f4178ee). Report is 28 commits behind head on main.
see 5 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 22d9fdf...f4178ee. Read the comment docs.
@byhlel can we have a quick talk in slack or wechat in case this is in the wrong direction
Yes on slack, my email: [email protected]
Have you joined this channel https://cloud-native.slack.com/archives/C06BU2GB8NL, and then you can contact with Zhonghu Xu
@byhlel Can you please update
Updated per our discussion
@byhlel I have left some message to you in slack
ping @byhlel please update