kmesh-net
Improve copyright checker
Task description:
We can add a copyright checker to prevent creating files without copyright https://github.com/kmesh-net/kmesh/blob/main/pkg/utils/exec.go#L1-L14
And for .c .h files, https://github.com/kmesh-net/kmesh/blob/main/bpf/deserialization_to_bpf_map/deserialization_to_bpf_map.c#L2
Solution:
Who can join or take the task:
The good first issue is intended for first-time contributors to get started on his/her contributor journey.
After a contributor has successfully completed 1-2 good first issue's,
they should be ready to move on to help wanted items, saving the remaining good first issue for other new contributors.
How to join or take the task:
Just reply on the issue with the message /assign in a separate line.
Then, the issue will be assigned to you.
How to ask for help:
If you need help or have questions, please feel free to ask on this issue. The issue author or other members of the community will guide you through the contribution process.
hi @hzxuzhonghu I see that the copyright check ci is already in the code.
https://github.com/yuluo-yx/kmesh/blob/53caaa81015ea23eff89ff41a7be9a7bf0ae115d/.github/workflows/main.yml#L31
Yeah. But i kind of remember it did not fail this pr https://github.com/kmesh-net/kmesh/pull/853#discussion_r1759636317
Yeah. But i kind of remember it did not fail this pr #853 (comment)
This script may not be easy to use, I can refactor it using skywalking-eyes.
@hzxuzhonghu I deleted /pkg/controller/workloader/common.go locally and the shell script is fine, it works fine
maybe we don’t need to update?
go_dirs="$ROOT_DIR/pkg"
c_dirs="$ROOT_DIR/bpf"
From the script, we can see it only checks these two dirs. That;s not enough, we have many other packages
@hzxuzhonghu I've finished this issue, you can close it.
I am very interested in cloud native and traffic management. If you have other good questions or simple tasks, you can assign them to me and I will try to do them. Thank you very much 🤔
@LiZhenCheng9527: Closing this issue.
In response to this:
Done /close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
