kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

refactor mode judgement

Open YaoZengzeng opened this issue 1 year ago • 4 comments

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


YaoZengzeng avatar Sep 09 '24 07:09 YaoZengzeng

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kevin-wangzefeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar Sep 09 '24 07:09 kmesh-bot

Codecov Report

:x: Patch coverage is 4.34783% with 22 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 52.76%. Comparing base (c5b6f8d) to head (254c71f). :warning: Report is 1317 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cni/install.go 0.00% 13 Missing :warning:
pkg/controller/client.go 0.00% 5 Missing and 1 partial :warning:
pkg/utils/test/bpf_map.go 33.33% 1 Missing and 1 partial :warning:
pkg/logger/logger.go 0.00% 1 Missing :warning:

:x: Your patch check has failed because the patch coverage (4.34%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Files with missing lines Coverage Δ
pkg/controller/controller.go 0.00% <ø> (ø)
pkg/logger/logger.go 35.63% <0.00%> (ø)
pkg/utils/test/bpf_map.go 41.46% <33.33%> (-2.13%) :arrow_down:
pkg/controller/client.go 61.79% <0.00%> (-4.47%) :arrow_down:
pkg/cni/install.go 37.70% <0.00%> (+1.19%) :arrow_up:

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 25f8959...254c71f. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Sep 09 '24 07:09 codecov[bot]

/retest

YaoZengzeng avatar Sep 09 '24 07:09 YaoZengzeng

/lgtm

LiZhenCheng9527 avatar Sep 10 '24 01:09 LiZhenCheng9527