kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

Increased stability of metric asynchronous execution

Open LiZhenCheng9527 opened this issue 1 year ago • 2 comments

What type of PR is this? /kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


LiZhenCheng9527 avatar Aug 13 '24 12:08 LiZhenCheng9527

Codecov Report

Attention: Patch coverage is 61.90476% with 8 lines in your changes missing coverage. Please review.

Project coverage is 53.37%. Comparing base (9db2d28) to head (3a0f2a6). Report is 268 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/telemetry/metric.go 61.90% 8 Missing :warning:
Files with missing lines Coverage Δ
pkg/controller/telemetry/metric.go 80.00% <61.90%> (+26.21%) :arrow_up:

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 835d85e...3a0f2a6. Read the comment docs.

codecov[bot] avatar Aug 13 '24 12:08 codecov[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign nlgwcy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar Aug 19 '24 12:08 kmesh-bot

This is no longer necessary.

LiZhenCheng9527 avatar Oct 08 '24 02:10 LiZhenCheng9527