kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

Improve cni uninstall

Open hzxuzhonghu opened this issue 1 year ago • 2 comments

What type of PR is this?

What this PR does / why we need it:

Do calling stop even start failed

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


hzxuzhonghu avatar Aug 13 '24 11:08 hzxuzhonghu

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 52.08%. Comparing base (cec9652) to head (9db2d28). Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cni/install.go 0.00% 7 Missing :warning:
pkg/cni/chained.go 0.00% 4 Missing :warning:
Files with missing lines Coverage Δ
pkg/cni/chained.go 37.63% <0.00%> (-0.62%) :arrow_down:
pkg/cni/install.go 17.64% <0.00%> (-2.36%) :arrow_down:

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ad05466...9db2d28. Read the comment docs.

codecov[bot] avatar Aug 13 '24 11:08 codecov[bot]

/assign @YaoZengzeng @nlgwcy

hzxuzhonghu avatar Aug 14 '24 08:08 hzxuzhonghu

/lgtm

bitcoffeeiux avatar Aug 29 '24 13:08 bitcoffeeiux

/lgtm /approve

nlgwcy avatar Aug 31 '24 03:08 nlgwcy

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlgwcy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar Aug 31 '24 03:08 kmesh-bot

@supercharge-xsy

nlgwcy avatar Aug 31 '24 04:08 nlgwcy