kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

Fix missing default oncn-mda default startup file

Open jiayoukun opened this issue 1 year ago • 11 comments

In the new dockerfile, you are missing the default startup file /etc/oncn-mda/oncn-mda.conf. @hzxuzhonghu

jiayoukun avatar Aug 13 '24 03:08 jiayoukun

Welcome @jiayoukun! It looks like this is your first PR to kmesh-net/kmesh 🎉

kmesh-bot avatar Aug 13 '24 03:08 kmesh-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.77%. Comparing base (89cdacd) to head (220f44a). Report is 18 commits behind head on main.

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 89cdacd...220f44a. Read the comment docs.

codecov[bot] avatar Aug 13 '24 03:08 codecov[bot]

/assign @lec-bit

hzxuzhonghu avatar Aug 14 '24 08:08 hzxuzhonghu

请查看https://github.com/kmesh-net/kmesh/blob/main/hack/utils.sh#L42-L58

这列出了我们之前建造的

COPY out/$arch/*so* /usr/lib64/
COPY out/$arch/*.o /usr/share/oncn-mda/
COPY out/$arch/oncn-mda.conf /etc/oncn-mda/
COPY out/$arch/kmesh-daemon /usr/bin/
COPY out/$arch/kmesh-cni /usr/bin/
COPY out/$arch/mdacore /usr/bin/
COPY build/docker/start_kmesh.sh /kmesh
COPY out/$arch/ko /kmesh

所以我们应该

COPY --from=builder /kmesh/oncn-mda/build/ebpf_src/CMakeFiles/sock_redirect.dir/sock_redirect.c.o /usr/share/oncn-mda/
 COPY --from=builder /kmesh/oncn-mda/build/ebpf_src/CMakeFiles/sock_ops.dir/sock_ops.c.o /usr/share/oncn-mda/

复制 --from=builder /kmesh/oncn-mda/etc/oncn-mda.conf /etc/oncn-mda/

It looks like using COPY --from=builder /kmesh/out/*.o /usr/share/oncn-mda/ It's the same, but I'm with you on that.

jiayoukun avatar Aug 14 '24 09:08 jiayoukun

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar Aug 15 '24 01:08 kmesh-bot

seems this is not needed now

hzxuzhonghu avatar Aug 19 '24 01:08 hzxuzhonghu

@hzxuzhonghu There are also the two issues I mentioned earlier in the commit: Reporting errors:time="2024-08-19T03:28:28Z" level=error msg="the config you input not unique to root, please modify permission of the config enable serviceMesh accelerating failed! " subsys=pkg/bpf

Modify the source of the oncn-mda.conf file to be: /etc/oncn-mda/oncn-mda.conf, since it was set to "chmod 600 /etc/oncn-mda/oncn-mda.conf" in build.sh.

Change the name of the file to official docs: "docker build --build-arg arch=amd64 -f build/docker/kmesh.dockerfile -t $image_name ."

jiayoukun avatar Aug 19 '24 03:08 jiayoukun

@weli-l @lec-bit Seems with the recent pr, i guess this is not needed

hzxuzhonghu avatar Aug 19 '24 03:08 hzxuzhonghu

@weli-l @lec-bit Seems with the recent pr, i guess this is not needed

Ok, you can try the latest version of mda, I just finished testing it and it wasn't fixed.

jiayoukun avatar Aug 19 '24 03:08 jiayoukun

BTW, there is a conflict please rebase

hzxuzhonghu avatar Aug 19 '24 03:08 hzxuzhonghu

BTW, there is a conflict please rebase

fix-pr

jiayoukun avatar Aug 19 '24 07:08 jiayoukun

Already fix this problem. /close

LiZhenCheng9527 avatar Jan 02 '25 08:01 LiZhenCheng9527

@LiZhenCheng9527: Closed this PR.

In response to this:

Already fix this problem. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kmesh-bot avatar Jan 02 '25 08:01 kmesh-bot