[WIP] do rbac in xdp prog
What type of PR is this? It's a continuation of the previous modification(https://github.com/kmesh-net/kmesh/pull/680)
What this PR does / why we need it:
Which issue(s) this PR fixes: Fixes #655
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/retest
/retest
Codecov Report
Attention: Patch coverage is 29.05405% with 105 lines in your changes missing coverage. Please review.
Project coverage is 52.80%. Comparing base (
9bef054) to head (4c6d933). Report is 74 commits behind head on main.
| Files with missing lines | Coverage Δ | |
|---|---|---|
| pkg/auth/policy_store.go | 68.33% <ø> (ø) |
|
| pkg/bpf/bpf_kmesh_workload.go | 60.82% <100.00%> (+0.37%) |
:arrow_up: |
| pkg/controller/workload/bpfcache/fake_map.go | 83.05% <81.81%> (-0.29%) |
:arrow_down: |
| pkg/controller/workload/bpfcache/auth_policy.go | 33.33% <33.33%> (ø) |
|
| pkg/bpf/bpf_kmesh_l4_workload.go | 38.37% <53.57%> (+7.33%) |
:arrow_up: |
| pkg/controller/workload/workload_processor.go | 62.81% <24.07%> (-5.99%) |
:arrow_down: |
| pkg/cache/v2/maps/authz.go | 0.00% <0.00%> (ø) |
... and 9 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update b7ebf49...4c6d933. Read the comment docs.
@tacslon @nlgwcy
Overall LGTM. Looks a little heavy to support only dst port match
yeah, The first pr involves policy-level parsing. This part can be reused when other match-type is added later.
@tacslon @weli-l any other comment ?
/lgtm
/lgtm
@nlgwcy @hzxuzhonghu can this pr be merged?
Need to take a last look
It is better to add some design documents for understanding.
/retest
@nlgwcy @hzxuzhonghu
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hzxuzhonghu, nlgwcy
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [hzxuzhonghu,nlgwcy]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
can we add a e2e case for it now