kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

Fix argument list too long in manage controller

Open tacslon opened this issue 1 year ago • 4 comments

What type of PR is this?

/kind cleanup What this PR does / why we need it: Fix argument list too long in manage controller in https://github.com/kmesh-net/kmesh/pull/679 Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

tacslon avatar Aug 09 '24 09:08 tacslon

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.16%. Comparing base (764f121) to head (fdca0a7). Report is 28 commits behind head on main.

Files with missing lines Coverage Δ
pkg/controller/manage/manage_controller.go 55.06% <100.00%> (-0.74%) :arrow_down:
pkg/utils/enroll.go 94.44% <100.00%> (+0.21%) :arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c9634e1...fdca0a7. Read the comment docs.

codecov[bot] avatar Aug 09 '24 09:08 codecov[bot]

An alternatrive maybe make these functions as a method of KmeshManageController, tehn you donot need to pass these args

This seems to be more reasonable, please make a review @hzxuzhonghu

tacslon avatar Aug 13 '24 01:08 tacslon

@hzxuzhonghu Please review

tacslon avatar Sep 30 '24 02:09 tacslon

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar Oct 08 '24 01:10 kmesh-bot