kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

FIX: go test timeout after running benchmark test

Open hzxuzhonghu opened this issue 1 year ago • 6 comments

…timeout

What type of PR is this?

What this PR does / why we need it:

Without cleaning up hash file, test will fail with timeout error. By default vs plugin set 30s timeout.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


hzxuzhonghu avatar Aug 08 '24 09:08 hzxuzhonghu

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.20%. Comparing base (433592b) to head (4e84096). Report is 8 commits behind head on main.

Files Coverage Δ
pkg/controller/workload/workload_hash.go 82.45% <100.00%> (+0.97%) :arrow_up:

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dda7049...4e84096. Read the comment docs.

codecov[bot] avatar Aug 08 '24 10:08 codecov[bot]

/retest

hzxuzhonghu avatar Aug 08 '24 11:08 hzxuzhonghu

/retest

hzxuzhonghu avatar Aug 08 '24 11:08 hzxuzhonghu

@nlgwcy @supercharge-xsy Can you please take a look

hzxuzhonghu avatar Aug 12 '24 06:08 hzxuzhonghu

/lgtm

LiZhenCheng9527 avatar Aug 12 '24 06:08 LiZhenCheng9527

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar Aug 14 '24 08:08 kmesh-bot