kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

Filter out unhealthy workloads

Open hzxuzhonghu opened this issue 1 year ago • 3 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #693

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


hzxuzhonghu avatar Aug 06 '24 12:08 hzxuzhonghu

Codecov Report

Attention: Patch coverage is 26.08696% with 17 lines in your changes missing coverage. Please review.

Project coverage is 53.23%. Comparing base (9bef054) to head (c5b6f8d). Report is 96 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/workload/workload_processor.go 26.08% 15 Missing and 2 partials :warning:
Files with missing lines Coverage Δ
pkg/controller/workload/workload_processor.go 66.83% <26.08%> (-1.97%) :arrow_down:

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b7ebf49...c5b6f8d. Read the comment docs.

codecov[bot] avatar Aug 06 '24 13:08 codecov[bot]

/lgtm

LiZhenCheng9527 avatar Aug 08 '24 01:08 LiZhenCheng9527

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar Aug 14 '24 08:08 kmesh-bot

@LiZhenCheng9527 Can you take another look

hzxuzhonghu avatar Sep 10 '24 02:09 hzxuzhonghu

/lgtm

LiZhenCheng9527 avatar Sep 11 '24 01:09 LiZhenCheng9527