kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

Donot start up kmesh manage controller when bypass enabled

Open hzxuzhonghu opened this issue 1 year ago • 2 comments

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #637

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


hzxuzhonghu avatar Jul 29 '24 08:07 hzxuzhonghu

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from hzxuzhonghu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar Jul 29 '24 08:07 kmesh-bot

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Project coverage is 49.62%. Comparing base (4a7807b) to head (05f119b). Report is 23 commits behind head on main.

Files Coverage Δ
pkg/controller/manage/manage_controller.go 44.61% <ø> (+0.67%) :arrow_up:
pkg/utils/enroll.go 94.33% <100.00%> (+0.46%) :arrow_up:
pkg/logger/logger.go 40.25% <0.00%> (+4.62%) :arrow_up:
pkg/controller/workload/workload_controller.go 62.00% <0.00%> (-2.59%) :arrow_down:
pkg/controller/controller.go 41.17% <69.23%> (+41.17%) :arrow_up:

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update df8b1b0...05f119b. Read the comment docs.

codecov[bot] avatar Jul 29 '24 09:07 codecov[bot]