kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

support large scale for ads mode

Open nlgwcy opened this issue 1 year ago • 2 comments

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


nlgwcy avatar Jul 18 '24 15:07 nlgwcy

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.12%. Comparing base (0c5498c) to head (6856384). Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
pkg/bpf/bpf.go 50.00% 2 Missing and 1 partial :warning:
Files with missing lines Coverage Δ
pkg/bpf/bpf.go 43.60% <50.00%> (+2.53%) :arrow_up:

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 20cb2d8...6856384. Read the comment docs.

codecov[bot] avatar Jul 19 '24 12:07 codecov[bot]

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository. Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kmesh-bot avatar Sep 21 '24 15:09 kmesh-bot

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository. Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kmesh-bot avatar Sep 25 '24 12:09 kmesh-bot

/lgtm

hzxuzhonghu avatar Sep 27 '24 01:09 hzxuzhonghu

/retest

hzxuzhonghu avatar Sep 27 '24 02:09 hzxuzhonghu

/retest

nlgwcy avatar Sep 27 '24 05:09 nlgwcy

TestRestartReload Still failed

hzxuzhonghu avatar Sep 27 '24 06:09 hzxuzhonghu

/lgtm

hzxuzhonghu avatar Sep 27 '24 08:09 hzxuzhonghu

/approve

hzxuzhonghu avatar Sep 27 '24 08:09 hzxuzhonghu

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar Sep 27 '24 08:09 kmesh-bot

In response to a cherrypick label: #610 failed to apply on top of branch "release-0.5":

Applying: support lage scale for ads mode
Using index info to reconstruct a base tree...
M	bpf/deserialization_to_bpf_map/deserialization_to_bpf_map.c
M	bpf/deserialization_to_bpf_map/deserialization_to_bpf_map.h
Falling back to patching base and 3-way merge...
Auto-merging bpf/deserialization_to_bpf_map/deserialization_to_bpf_map.h
Auto-merging bpf/deserialization_to_bpf_map/deserialization_to_bpf_map.c
CONFLICT (content): Merge conflict in bpf/deserialization_to_bpf_map/deserialization_to_bpf_map.c
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 support lage scale for ads mode
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

kmesh-bot avatar Sep 27 '24 08:09 kmesh-bot

In response to a cherrypick label: new issue created for failed cherrypick: #907

kmesh-bot avatar Sep 27 '24 08:09 kmesh-bot