kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

fix dns cannot remove domain bug

Open PerforMance308 opened this issue 1 year ago • 4 comments

What type of PR is this? /kind bug

What this PR does / why we need it: image

Stow solution. should send dnsClusters to DNS resolver even if it is empty so that the resolver could remove unwatched domains. Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


PerforMance308 avatar Jul 18 '24 14:07 PerforMance308

LG

Do we have a case covering the domain can be removed correctly

hzxuzhonghu avatar Jul 19 '24 01:07 hzxuzhonghu

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kevin-wangzefeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar Jul 23 '24 18:07 kmesh-bot

added ut for checking the domain can be removed correctly

PerforMance308 avatar Jul 23 '24 18:07 PerforMance308

@PerforMance308 Could you update the tests and we can merge

hzxuzhonghu avatar Aug 12 '24 12:08 hzxuzhonghu