kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

support remove residual endpoints

Open nlgwcy opened this issue 1 year ago • 6 comments

What type of PR is this?

/kind enhancement

What this PR does / why we need it: The current code cannot process the following scenarios:

  1. The workload is used as the endpoint of service1 and service2.
  2. Later, the workload is removed from service2. In this case, the workload and service2 records in the endpoint are not deleted. As a result, subsequent service access requests are distributed to an incorrect endpoint.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


nlgwcy avatar Jul 18 '24 12:07 nlgwcy

Please add some description under what circumustance this can happen

hzxuzhonghu avatar Jul 18 '24 12:07 hzxuzhonghu

Codecov Report

Attention: Patch coverage is 69.07216% with 60 lines in your changes missing coverage. Please review.

Project coverage is 52.28%. Comparing base (bda21d4) to head (c544239). Report is 34 commits behind head on main.

Files Patch % Lines
pkg/controller/workload/workload_processor.go 62.01% 39 Missing and 10 partials :warning:
pkg/controller/workload/cache/workload_cache.go 82.81% 8 Missing and 3 partials :warning:
Files Coverage Δ
pkg/bpf/bpf.go 42.59% <ø> (+0.51%) :arrow_up:
pkg/controller/workload/bpfcache/fake_map.go 83.33% <100.00%> (+0.35%) :arrow_up:
pkg/controller/workload/cache/workload_cache.go 75.00% <82.81%> (+10.84%) :arrow_up:
pkg/controller/workload/workload_processor.go 64.66% <62.01%> (+1.98%) :arrow_up:

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 74ff6c8...c544239. Read the comment docs.

codecov[bot] avatar Jul 18 '24 12:07 codecov[bot]

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository. Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kmesh-bot avatar Aug 04 '24 04:08 kmesh-bot

@nlgwcy Please resolve conflicts

hzxuzhonghu avatar Aug 05 '24 07:08 hzxuzhonghu

cc @hzxuzhonghu ready to be merged

nlgwcy avatar Aug 12 '24 01:08 nlgwcy

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository. Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kmesh-bot avatar Aug 15 '24 12:08 kmesh-bot

/retest

nlgwcy avatar Aug 15 '24 12:08 nlgwcy

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar Aug 16 '24 03:08 kmesh-bot