add proposal for Locality LoadBalance
What type of PR is this? /kind enhancement
What this PR does / why we need it: add proposal for Locality LB
Welcome @derekwin! It looks like this is your first PR to kmesh-net/kmesh 🎉
Would you like to share your issue at Thursday's community meeting?
/ok-to-test
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 52.80%. Comparing base (
433592b) to head (b2caa7c). Report is 217 commits behind head on main.
see 29 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update dda7049...b2caa7c. Read the comment docs.
Would you like to share your issue at Thursday's community meeting?
yes
I have updated the proposal.
Propose a new implementation for a location matching algorithm that avoids circular computations while also reducing the amount of data needed to be stored in BPF maps. detail: https://github.com/derekwin/treemap/tree/master Welcome to offer suggestions to further improve the approach.
if no conflict, there is no need to merge main branch. If there are some conflicts, to get a clearer commit history, you should:
git rebase main
then fix some conflicts, and then
git rebase --continue
git push --force
the DCO github action failed, because it asks you to commit with your signature, which can be attached with -s flag:
git commit -s -m 'something to say'
new proposal of locality LB in user-space logic
New design has been updated to the proposal and the correspond code Pr is here https://github.com/kmesh-net/kmesh/pull/900
@derekwin Does this need to update
Yes, By the way, do I need to write a document on how to use locality load balancing? If so, where should I push the locality load balancing documentation? (in docs or website?) Or is a simple document update sufficient?
Yeah, we need user guide for locality loadbalancer, you should file it into website repo. BTW, this is a refer for you https://istio.io/latest/docs/tasks/traffic-management/locality-load-balancing/
Yeah, we need user guide for locality loadbalancer, you should file it into website repo. BTW, this is a refer for you https://istio.io/latest/docs/tasks/traffic-management/locality-load-balancing/是的,我们需要 Locality LoadBalancer 的用户指南,您应该将其归档到 Website Repo 中。顺便说一句,这是为您推荐的 https://istio.io/latest/docs/tasks/traffic-management/locality-load-balancing/
ok.
I have updated the content of this proposal, and the documentation in the website repo will be updated soon.
@hzxuzhonghu
/lgtm
/lgtm
@hzxuzhonghu Can this PR be merged?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hzxuzhonghu
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [hzxuzhonghu]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment