kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

add proposal for Locality LoadBalance

Open derekwin opened this issue 1 year ago • 11 comments

What type of PR is this? /kind enhancement

What this PR does / why we need it: add proposal for Locality LB

derekwin avatar Jul 15 '24 06:07 derekwin

Welcome @derekwin! It looks like this is your first PR to kmesh-net/kmesh 🎉

kmesh-bot avatar Jul 15 '24 06:07 kmesh-bot

Would you like to share your issue at Thursday's community meeting?

LiZhenCheng9527 avatar Jul 15 '24 07:07 LiZhenCheng9527

/ok-to-test

hzxuzhonghu avatar Jul 16 '24 01:07 hzxuzhonghu

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.80%. Comparing base (433592b) to head (b2caa7c). Report is 217 commits behind head on main.

see 29 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dda7049...b2caa7c. Read the comment docs.

codecov[bot] avatar Jul 16 '24 01:07 codecov[bot]

Would you like to share your issue at Thursday's community meeting?

yes

derekwin avatar Jul 16 '24 03:07 derekwin

I have updated the proposal.

derekwin avatar Jul 25 '24 05:07 derekwin

Propose a new implementation for a location matching algorithm that avoids circular computations while also reducing the amount of data needed to be stored in BPF maps. detail: https://github.com/derekwin/treemap/tree/master Welcome to offer suggestions to further improve the approach.

derekwin avatar Jul 26 '24 11:07 derekwin

if no conflict, there is no need to merge main branch. If there are some conflicts, to get a clearer commit history, you should:

git rebase main

then fix some conflicts, and then

git rebase --continue
git push --force

the DCO github action failed, because it asks you to commit with your signature, which can be attached with -s flag:

git commit -s -m 'something to say'

Okabe-Rintarou-0 avatar Jul 30 '24 09:07 Okabe-Rintarou-0

new proposal of locality LB in user-space logic

derekwin avatar Sep 07 '24 09:09 derekwin

New design has been updated to the proposal and the correspond code Pr is here https://github.com/kmesh-net/kmesh/pull/900

derekwin avatar Sep 28 '24 03:09 derekwin

@derekwin Does this need to update

Yes, By the way, do I need to write a document on how to use locality load balancing? If so, where should I push the locality load balancing documentation? (in docs or website?) Or is a simple document update sufficient?

derekwin avatar Nov 21 '24 10:11 derekwin

Yeah, we need user guide for locality loadbalancer, you should file it into website repo. BTW, this is a refer for you https://istio.io/latest/docs/tasks/traffic-management/locality-load-balancing/

hzxuzhonghu avatar Nov 22 '24 01:11 hzxuzhonghu

Yeah, we need user guide for locality loadbalancer, you should file it into website repo. BTW, this is a refer for you https://istio.io/latest/docs/tasks/traffic-management/locality-load-balancing/是的,我们需要 Locality LoadBalancer 的用户指南,您应该将其归档到 Website Repo 中。顺便说一句,这是为您推荐的 https://istio.io/latest/docs/tasks/traffic-management/locality-load-balancing/

ok.

derekwin avatar Nov 23 '24 08:11 derekwin

I have updated the content of this proposal, and the documentation in the website repo will be updated soon.

derekwin avatar Nov 26 '24 03:11 derekwin

@hzxuzhonghu

derekwin avatar Nov 26 '24 03:11 derekwin

/lgtm

LiZhenCheng9527 avatar Nov 27 '24 08:11 LiZhenCheng9527

/lgtm

LiZhenCheng9527 avatar Nov 27 '24 08:11 LiZhenCheng9527

@hzxuzhonghu Can this PR be merged?

LiZhenCheng9527 avatar Dec 12 '24 11:12 LiZhenCheng9527

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar Dec 13 '24 06:12 kmesh-bot